Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

actions: Support python 3.10 #129

Merged
merged 5 commits into from Apr 26, 2022
Merged

actions: Support python 3.10 #129

merged 5 commits into from Apr 26, 2022

Conversation

Luke31
Copy link
Contributor

@Luke31 Luke31 commented Apr 26, 2022 •
edited

Why

  • Currently python 3.10 is not officially supported and tested
  • python-version as number 3.10 is parsed as 3.1
    image

What

  • Run commit-tests with python 3.10
  • Change python-version to string as 3.10 would else be parsed as 3.1

Additional info

@Luke31 Luke31 changed the title feat: run commit checks with python 3.10 Run commit checks with python 3.10 Apr 26, 2022
@Luke31 Luke31 marked this pull request as ready for review April 26, 2022 06:17
@Luke31 Luke31 changed the title Run commit checks with python 3.10 actions: run commit checks with python 3.10 Apr 26, 2022
@Luke31 Luke31 changed the title actions: run commit checks with python 3.10 actions: support python 3.10 Apr 26, 2022
@Luke31 Luke31 mentioned this pull request Apr 26, 2022
Closed
@Luke31 Luke31 changed the title actions: support python 3.10 support python 3.10 Apr 26, 2022
@Luke31 Luke31 changed the title support python 3.10 Support python 3.10 Apr 26, 2022
@Luke31
Copy link
Contributor Author

Luke31 commented Apr 26, 2022

@trallnag I couldn't add you as a reviewer so I just tag you here. What do you think of updating to python 3.10?

@Luke31 Luke31 changed the title Support python 3.10 actions: Support python 3.10 Apr 26, 2022
@trallnag
Copy link
Owner

I'll look at it this evening. Sorry, but I've been neglecting this project as I'm not using it personally atm

@Luke31
Copy link
Contributor Author

Luke31 commented Apr 26, 2022

I'll look at it this evening. Sorry, but I've been neglecting this project as I'm not using it personally atm

@trallnag Thanks, absolutely no need to hurry. If you need any help just let me know.

trallnag
trallnag approved these changes Apr 26, 2022
View reviewed changes
Copy link
Owner

@trallnag trallnag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@trallnag trallnag merged commit 673f12b into trallnag:master Apr 26, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2022

🎉 This PR is included in version 5.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trallnag trallnag trallnag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Luke31 @trallnag