Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove print statement from middleware #157

Merged

Conversation

nikstuckenbrock
Copy link
Contributor

@nikstuckenbrock nikstuckenbrock commented Jun 30, 2022

As mentioned in issue #156 and #151 the middleware prints at sometime.
I simply removed the print statement.

@levrik levrik mentioned this pull request Jul 4, 2022
@timurstrekalov
Copy link

👍

@letmerecall
Copy link

Thanks for this one :)

@letmerecall
Copy link

Anyone who can merge this? Having this print statement is really really annoying.

cc: @trallnag @mander1000

@kitofr
Copy link

kitofr commented Aug 8, 2022

➕ on this one... have been hunting this down today.

@BrettMoan
Copy link

this was a source of insanity for us! and i'm very happy i found this, but am disappointed that it has not yet been fixed.

@majedtaki
Copy link

@trallnag @mander1000 Can we merge this please?

@haf
Copy link

haf commented Aug 19, 2022

Hello?! @trallnag

@timurstrekalov
Copy link

In the meantime, my Splunk is going
True
True
True

@haf
Copy link

haf commented Aug 19, 2022

Oh, wow you have True, mine is always False. Lucky you ;)

@timurstrekalov
Copy link

Oh, wow you have True, mine is always False. Lucky you ;)

That extra letter is going to cost you 😆

@kitofr
Copy link

kitofr commented Aug 22, 2022

At least @trallnag moved some files this weekend... hopefully picking this one up soon as well.

@trallnag trallnag force-pushed the bugfix/remove-print-from-middleware branch from b8dac0b to e1669c8 Compare August 22, 2022 12:51
@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #157 (e1669c8) into master (8f72053) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #157      +/-   ##
==========================================
- Coverage   93.51%   93.48%   -0.03%     
==========================================
  Files           4        4              
  Lines         262      261       -1     
==========================================
- Hits          245      244       -1     
  Misses         17       17              
Impacted Files Coverage Δ
...rc/prometheus_fastapi_instrumentator/middleware.py 88.75% <ø> (-0.14%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@trallnag trallnag merged commit f89792b into trallnag:master Aug 22, 2022
@timurstrekalov
Copy link

🍾 for everyone! Thanks!

This was linked to issues Aug 22, 2022
@trallnag trallnag linked an issue Aug 22, 2022 that may be closed by this pull request
@letmerecall
Copy link

Thanks for giving a reason to celebrate today 😉

@kitofr
Copy link

kitofr commented Aug 30, 2022

Cheers 🍾

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Print in middleware component Unexpected print in Middleware
9 participants