Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README to initialize instrumentator after app startup #168

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

mdczaplicki
Copy link
Contributor

No description provided.

@trallnag
Copy link
Owner

What is the advantage of doing it like this?

@mdczaplicki
Copy link
Contributor Author

mdczaplicki commented Aug 23, 2022

The advantage is that it works only like this.
With regards to this #80

@trallnag trallnag linked an issue Aug 23, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #168 (44381aa) into master (3f1c500) will decrease coverage by 0.31%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #168      +/-   ##
==========================================
- Coverage   93.48%   93.17%   -0.32%     
==========================================
  Files           4        4              
  Lines         261      249      -12     
==========================================
- Hits          244      232      -12     
  Misses         17       17              
Impacted Files Coverage Δ
...ometheus_fastapi_instrumentator/instrumentation.py 90.90% <0.00%> (-0.32%) ⬇️
src/prometheus_fastapi_instrumentator/metrics.py 97.29% <0.00%> (-0.23%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@trallnag trallnag merged commit dc36aac into trallnag:master Aug 23, 2022
@trallnag
Copy link
Owner

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instrumentator appears to be broken with the latest FastAPI
2 participants