Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permissions-based approval system #424

Open
kitallis opened this issue Apr 13, 2023 · 0 comments
Open

Permissions-based approval system #424

kitallis opened this issue Apr 13, 2023 · 0 comments
Labels
big feature A substantial feature that should be broken down into small issues category / sign-offs

Comments

@kitallis
Copy link
Member

Proposal

a.k.a sign-offs.

Certain users or a group of users have the authority to stop a release train from moving ahead. They can reject builds as faulty or completely halt the release from happening.

These users may typically be QAs (in a large team) on a more continuous basis or they could be business stakeholders involved in engineering on a less frequent basis.

What this achieves / problem(s) it solves

The assigned users might be able to:

  • Stop the release team from deploying to any further channels
  • Stop the release team from create new releases
  • Approving or reject certain fixes to a release
  • Having the final say in the release to a production store

Additionally,

  • Be able to submit a reason (review notes) for acceptance or rejection per build or per release
  • Be able to tentatively approve with review notes, even if the release is not 100% golden

This system is similar to the GitHub / GitLab PR approval system

Additional context

The users who are selected for this approval system should ideally only be of a certain role or permission.

We have previously built a simple sign-offs system that is now defunct.

@kitallis kitallis added big feature A substantial feature that should be broken down into small issues category / sign-offs labels Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
big feature A substantial feature that should be broken down into small issues category / sign-offs
Projects
Status: In progress
Development

No branches or pull requests

1 participant