Skip to content

Commit

Permalink
fix(eslint-config, eslint-config-react): update rules (#53)
Browse files Browse the repository at this point in the history
* fix(eslint-config, eslint-config-react): update rules

* add Tom910 and SuperOleg39 to CODEOWNERS

Co-authored-by: o.drapeza <o.drapeza@tinkoff.ru>
  • Loading branch information
SuperOleg39 and o.drapeza committed Jul 8, 2020
1 parent 898a74c commit 40cc0b1
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
Validating CODEOWNERS rules …
Expand Up @@ -9,5 +9,5 @@
# More info: https://help.github.com/articles/about-codeowners/
#

* @YuliaTsareva @MarsiBarsi @waterplea @nezed
* @YuliaTsareva @MarsiBarsi @waterplea @nezed @Tom910 @SuperOleg39
# will be requested for review when someone opens a pull request
2 changes: 1 addition & 1 deletion packages/eslint-config-react/index.js
Expand Up @@ -48,7 +48,7 @@ module.exports = {
'react/jsx-key': 'error',
'react/no-direct-mutation-state': 'error',
'react/default-props-match-prop-types': 'warn',
'react/require-default-props': 'warn',
'react/require-default-props': 'off', // default values in props destructuring is not supported
'react/static-property-placement': ['error', 'static public field'],

'react/sort-comp': [
Expand Down
6 changes: 4 additions & 2 deletions packages/eslint-config/internal/typescript.js
Expand Up @@ -69,7 +69,9 @@ module.exports = {
],
// '@typescript-eslint/no-unnecessary-qualifier': 'error', need ts config
// '@typescript-eslint/restrict-plus-operands': 'error', need ts config
'@typescript-eslint/no-explicit-any': 'warn',
'@typescript-eslint/no-explicit-any': 'off',
camelcase: 'off',
'@typescript-eslint/camelcase': 'off',
'@typescript-eslint/naming-convention': [
'error',
{
Expand All @@ -86,7 +88,7 @@ module.exports = {
},
{
selector: 'typeLike',
format: ['PascalCase'],
format: ['PascalCase', 'UPPER_CASE'],
},
{
selector: 'property',
Expand Down

0 comments on commit 40cc0b1

Please sign in to comment.