Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update 'eslint-config with 'unicorn' plugin rules #19

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

0leg53
Copy link

@0leg53 0leg53 commented Feb 14, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

eslint-config is fine to:

  • escape hex in different ways
  • set eslint-disable comment to disable entire rules list
  • make instanceof Array instead Array.isArray()
  • ...some other mismatches which allows to write one functional code in different ways

What is the new behavior?

  • eslint-config become more strict for these cases

Does this PR introduce a breaking change?

  • Yes
  • No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant