Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VCV browser crash #2

Closed
transcriptaze opened this issue Jan 24, 2024 · 3 comments
Closed

VCV browser crash #2

transcriptaze opened this issue Jan 24, 2024 · 3 comments
Assignees

Comments

@transcriptaze
Copy link
Owner

transcriptaze commented Jan 24, 2024

Ref. https://community.vcvrack.com/t/right-click-death/21473/9

When I right click and attempt to add a module, the whole thing crashes. Deleted my Squink product, still crashes. What do I do now? I looked at the log file, and I really don’t know what I’m looking for. Has anybody had the same problem?

@transcriptaze
Copy link
Owner Author

transcriptaze commented Jan 25, 2024

Here is the last bunch of spewage from my log file: … 
[782.180 fatal adapters/standalone.cpp:49 fatalSignalHandler] 
Fatal signal 11. Stack trace: 
33: 0x0 
32: 0x0 
31: _C_specific_handler 0x771471cc 
30: _chkstk 0x7715be00 
29: RtlInitializeResource 0x7712fed0 
28: KiUserExceptionDispatcher 0x7715b510 
27: ZN4rack3app9SvgSwitch8addFrameESt10shared_ptrINS_6window3SvgEE 0x7feec59a110 
26: ZN11EModeSliderC1Ev 0x7fef62e3516 
25: ZN12SN_VCOWidgetC1EP6SN_VCO 0x7fef62f5890 
24: ZZN4rack11createModelI6SN_VCO12SN_VCOWidgetEEPNS_6plugin5ModelENSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEEN6TModel18createModuleWidgetEPNS_6engine6ModuleE 0x7fef6305720 
23: ZN4rack3app7browser8ModelBox4drawERKNS_6widget6Widget8DrawArgsE 0x7feeca11d60 
22: ZN4rack6widget6Widget9drawChildEPS1_RKNS1_8DrawArgsEi 0x7feec5b7e70 
21: ZN4rack6widget6Widget4drawERKNS1_8DrawArgsE 0x7feec5b7fe0 
20: ZN4rack6widget6Widget9drawChildEPS1_RKNS1_8DrawArgsEi 0x7feec5b7e70 
19: ZN4rack6widget6Widget4drawERKNS1_8DrawArgsE 0x7feec5b7fe0 
18: ZN4rack6widget6Widget9drawChildEPS1_RKNS1_8DrawArgsEi 0x7feec5b7e70 
17: ZN4rack6widget6Widget4drawERKNS1_8DrawArgsE 0x7feec5b7fe0 
16: ZN4rack6widget6Widget9drawChildEPS1_RKNS1_8DrawArgsEi 0x7feec5b7e70 
15: ZN4rack6widget6Widget4drawERKNS1_8DrawArgsE 0x7feec5b7fe0 
14: ZN4rack2ui12ScrollWidget4drawERKNS_6widget6Widget8DrawArgsE 0x7feec5b00b0 
13: ZN4rack6widget6Widget9drawChildEPS1_RKNS1_8DrawArgsEi 0x7feec5b7e70 
12: ZN4rack6widget6Widget4drawERKNS1_8DrawArgsE 0x7feec5b7fe0 
11: ZN4rack6widget6Widget9drawChildEPS1_RKNS1_8DrawArgsEi 0x7feec5b7e70 
10: ZN4rack6widget6Widget4drawERKNS1_8DrawArgsE 0x7feec5b7fe0 
9: ZN4rack6widget6Widget9drawChildEPS1_RKNS1_8DrawArgsEi 0x7feec5b7e70 
8: ZN4rack6widget6Widget4drawERKNS1_8DrawArgsE 0x7feec5b7fe0 
7: ZN4rack6window6Window4stepEv 0x7feec5b9eb0 
6: ZN4rack6window6Window3runEv 0x7feec5ba8b0 
5: ZN4rack6window6Window3runEv 0x7feec5ba8b0 
4: ZN4rack6window6Window3runEv 0x7feec5ba8b0 
3: ZN4rack6window6Window3runEv 0x7feec5ba8b0 
2: ZN4rack6window6Window3runEv 0x7feec5ba8b0 
1: BaseThreadInitThunk 0x76fe5560 
0: RtlUserThreadStart 0x77143710 …

@twystd twystd changed the title Add check for NULL module in ModuleWidget Fix VCV browser crash on Windows Jan 28, 2024
@twystd twystd changed the title Fix VCV browser crash on Windows VCV browser crash on Windows Jan 28, 2024
@twystd twystd changed the title VCV browser crash on Windows VCV browser crash Jan 28, 2024
@twystd
Copy link
Collaborator

twystd commented Jan 28, 2024

Crash is happening in SvgSwitch::addFrame:

void SvgSwitch::addFrame(std::shared_ptr<window::Svg> svg) {
	frames.push_back(svg);
	// If this is our first frame, automatically set SVG and size
	if (!sw->svg) {
		sw->setSvg(svg);
		box.size = sw->box.size;
		fb->box.size = sw->box.size;
		// Move shadow downward by 10%
		shadow->box.size = sw->box.size;
		shadow->box.pos = math::Vec(0, sw->box.size.y * 0.10);
	}
}

@transcriptaze
Copy link
Owner Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants