Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exact name match doesn't return result even if data present #133

Open
3 tasks done
isabellasoldner opened this issue Mar 11, 2024 · 0 comments
Open
3 tasks done

Exact name match doesn't return result even if data present #133

isabellasoldner opened this issue Mar 11, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@isabellasoldner
Copy link

Checklist

  • I have checked that this issue has not already been reported.

  • I have confirmed this bug exists on the latest version of feo-client.

  • I have confirmed this bug exists on the main branch of feo-client.

Reproducible Example

When searching for a power plant that is definitely present we had to lower the threshold from the default of 0.5 to 0.3 to get the power plant out. I would consider "Gravelines" to be as an exact of a match as possible for this plant (since the rest of the name is the generic "nuclear plant") so I would not expect to have to lower the threshold to get the correct plant out.

  • potentially need to remove or downvalue “power plant” or “nuclear” and other fuel types significantl
  • potentially need to remove or downvalue “power plant” or “nuclear” and other fuel types significantl

search_results = Asset.search("Gravelines", sector="power", threshold=0.3, limit=10)
for asset in search_results:
    print(asset.id, asset.name_primary_en)

Nothing returns using default threshold of 0.5 in this case

There are announced units for this plant that have not beeen returned (maybe they are not in the old dataset)

Issue Description

see above

Expected Behavior

I would expect the default threshold to return a plant I definitely know is there with the unique part of its name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant