Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rendering bug for some aspect ratios #7

Closed
transitive-bullshit opened this issue Feb 25, 2018 · 2 comments · Fixed by #29
Closed

rendering bug for some aspect ratios #7

transitive-bullshit opened this issue Feb 25, 2018 · 2 comments · Fixed by #29
Labels

Comments

@transitive-bullshit
Copy link
Owner

transitive-bullshit commented Feb 25, 2018

There's currently an bug where some video dimensions result in warped, funky-looking transitions.

I'm not sure exactly what the bug is, but my best guess is that it has to do with how AVFrame represents its frame data. It seems that AVFrame adds padding to each line to maximize use of SIMD. We're definitely not accounting for this padding, and I think that's what's causing the issue for some video sizes.

Adding this here to track progress.

@nudja
Copy link

nudja commented Aug 31, 2018

I have experienced this problem quite a lot on a mac. If I change the aspect ratio of the files then the problem can go away but I have not formulated a pattern yet.

What I have noticed, if it helps, is that the default transition seems to work on all files that otherwise fail with a more complex transition. Does that help?

@transitive-bullshit
Copy link
Owner Author

Yeah, I know why it's happening, just haven't had the time or motivation to fix it since I'm no longer actively using this in my project (switched to ffmpeg-concat).

The reason it doesn't repro for the simple fade transition is because the fade transition maps each input pixel directly to an output pixel.

The problem happens because ffmpeg internally adds padding to each row of memory with some video resolutions, and this implementation doesn't take this into consideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants