Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show button in search bar #388

Closed
aaronliu0130 opened this issue Aug 20, 2023 · 6 comments
Closed

Show button in search bar #388

aaronliu0130 opened this issue Aug 20, 2023 · 6 comments
Labels
questions Further information is requested

Comments

@aaronliu0130
Copy link

screenshot showing rightmost part of search bar showing a translate icon and a bookmark icon
Some extensions like https://github.com/FilipePS/Traduzir-paginas-web put the button in the search bar. Could this extension do something similar?

@vitonsky
Copy link
Collaborator

Yes, this is possible, but only for a firefox. Why you wants to have this button and whats feature it should have?

@vitonsky vitonsky added the questions Further information is requested label Aug 20, 2023
@aaronliu0130
Copy link
Author

To host the extension itself (it could be an option) and glow when the page has been translated. I also just feel off on putting extra icons in the extensions' space in the toolbar.

@vitonsky
Copy link
Collaborator

vitonsky commented Aug 20, 2023

I got your idea, let's converse it.

Suggested behavior make sense to save space on extensions bar and to not add yet another icon.
But how users will start a page translation with no extension button on a bar? Think deep about it.

Probably some users would use a hotkeys to toggle page translation, but in this case a icon in omnibox not necessary at all.

@aaronliu0130
Copy link
Author

aaronliu0130 commented Aug 20, 2023

Same example with the other extension I've mentioned above:
omnibar button with modal open
You can also open modals with these buttons.

@vitonsky
Copy link
Collaborator

I see a potential in your idea, but i can't start development just to copy any behavior of another extension, it is not work like that.

If you really needed this feature - think deep about why you needs this feature and answer yourself for those questions:

  • why i want this feature?
  • what problem i have with no this feature?
  • how this feature will solve my problem?
  • how exactly this feature will works for me and for another people on other browsers and OS with another workflow
  • is i sure this feature is still useful?

When you will done with a reflection, come back and add more details

@aaronliu0130
Copy link
Author

I don't need it that much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
questions Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants