Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data-loading Makefile doesn't include step 7 from the README #52

Closed
gaurav opened this issue Apr 27, 2023 · 1 comment · Fixed by #54
Closed

Data-loading Makefile doesn't include step 7 from the README #52

gaurav opened this issue Apr 27, 2023 · 1 comment · Fixed by #54
Labels
good first issue Good for newcomers should be complete
Milestone
Name Resolver v2....

Comments

@gaurav
Copy link
Contributor

gaurav commented Apr 27, 2023

The data-loading Makefile doesn't currently contain instructions for step 7 of the README file:

NameResolution/data-loading/README.md

Lines 71 to 79 in 4af3db7

7. Generate the backup tarball. At the moment, this is expected to be in the format
`var/solr/data/snapshot.backup/[index files]`. The easiest way to generate this tarball correctly is to run:
```shell
$ mkdir -p data/var/solr/data
$ mv /var/solr/name_lookup_shard1_replica_n1/data/snapshot.backup data/var/solr/data
$ cd data
$ tar zcvf snapshot.backup.tar.gz var
```

This is particular silly because it's exactly four bash commands -- it'll be extremely easy to automate!
@gaurav gaurav added the good first issue Good for newcomers label Apr 27, 2023
@gaurav gaurav changed the title Data-loading Makefile doesn't include Data-loading Makefile doesn't include step 7 from the README Apr 27, 2023
@gaurav gaurav mentioned this issue Apr 27, 2023
Merged
@gaurav
Copy link
Contributor Author

gaurav commented Jun 22, 2023

PR #54 only needs a few more edits before we can close this issue.

gaurav added a commit that referenced this issue Jun 29, 2023
@gaurav
Merge pull request #54 from floor3d/master
2234ed6 
Added step 6 and step 7 to Makefile. Issue called for only step 7 to be added, so step 6 is currently commented out. Unsure if nomenclature is correct; to try to go with the pattern, made my own "data/[name]" title for the steps. Fixes #52.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers should be complete
Projects
None yet
Milestone
Name Resolver v2.0.0 (with updated sy...
Development

Successfully merging a pull request may close this issue.

Incorporate compressing Snapshot backup for loading into NameRes floor3d/NameResolution
1 participant
@gaurav