Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for filtering to a set of prefixes #66

Closed
gaurav opened this issue Jun 24, 2023 · 1 comment
Closed

Add support for filtering to a set of prefixes #66

gaurav opened this issue Jun 24, 2023 · 1 comment

Comments

@gaurav
Copy link
Contributor

gaurav commented Jun 24, 2023

Filtering to a set of prefixes would allow searches to take the view of a single ontology or identifier source, allowing large and detailed identifier sources like UMLS to be filtered out when not needed. The specific need here is from the UI, who have found that filtering to MONDO (and possibly HP) removes a lot of problematic matches, and would like NameRes to handle this so that they don't need to reduce the number of results when they filter these results at their end.

Theoretically, there are two ways in which we could do this:

  1. Filter only on the preferred identifier, i.e. concept A with a preferred ID of MONDO:1234 and a secondary ID of HP:4567 will be returned if filtering on MONDO but not if filtering on HP.
  2. Filter on any identifier, i.e. concept A with a preferred ID of MONDO:1234 and a secondary ID of HP:4567 will be returned if filtering on MONDO AND if filtering on HP, but not on other prefixes.

I think the first approach is fine for an initial implementation, but we can also implement the second if needed. Of course a complete implementation would included both filter_only_prefix and filter_out_prefix fields, but to meet this use-case we only need filter_only_prefix.

@gaurav
Copy link
Contributor Author

gaurav commented Sep 27, 2023

We have now implemented this for the first approach. Closing.

@gaurav gaurav closed this as completed Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant