Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Java code style linter #44

Closed
Acconut opened this issue Apr 19, 2021 · 2 comments
Closed

Add Java code style linter #44

Acconut opened this issue Apr 19, 2021 · 2 comments
Assignees
Labels
enhancement sdks Integrations for Transloadit's API

Comments

@Acconut
Copy link
Member

Acconut commented Apr 19, 2021

Now that we have Github Actions setup, it would be nice if it could also run a code linter on every commits to warn us about common mistakes and keep the code style consistent (indentation, spaces, unused variables etc). A common tool for this task seems to be super-linter (https://github.com/github/super-linter), which also supports Java.

@Acconut Acconut added enhancement sdks Integrations for Transloadit's API labels Apr 19, 2021
@cdr-chakotay
Copy link
Collaborator

I will have a peek on that. I guess we want it to check every commit and not only PRs to the Master branch?

@Acconut
Copy link
Member Author

Acconut commented Apr 21, 2021

Exactly! I think it would be best to have this as a separate job next to the Gradle step, so that both jobs, the linting and the tests, are always run even if one of them fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement sdks Integrations for Transloadit's API
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants