Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken thumbnail on dropbox #2576

Closed
ifedapoolarewaju opened this issue Oct 8, 2020 · 5 comments · Fixed by #3063
Closed

broken thumbnail on dropbox #2576

ifedapoolarewaju opened this issue Oct 8, 2020 · 5 comments · Fixed by #3063
Assignees
Labels
Bug Companion The auth server (for Instagram, GDrive, etc) and upload proxy (for S3)

Comments

@ifedapoolarewaju
Copy link
Contributor

When access companion on a domain different from the client domain, the dropbox thumbnails appear as broken images.

Screenshot 2020-10-08 at 11 46 32

The reason for this issue is because the dropbox thumbnail is an image url that requires cookie credentials to load. If the domains are different, the cookie will not be sent, hence the image will not load.

@ifedapoolarewaju ifedapoolarewaju self-assigned this Oct 8, 2020
@ifedapoolarewaju ifedapoolarewaju added the Companion The auth server (for Instagram, GDrive, etc) and upload proxy (for S3) label Oct 22, 2020
@onassar
Copy link

onassar commented Oct 24, 2020

We're running into this as well.

Here is our temporary fix using CSS for failed images:

The CSS for this is:

img.uppy-Dashboard-Item-previewImg::before {  
    content: " ";
    display: block;
    top: 0;
    position: absolute;
    width: 100%;
    height: 100%;
    background-color: rgb(230, 230, 230);
}

img.uppy-Dashboard-Item-previewImg::after {  
    content: "Preview not \A available";
    white-space: pre-wrap;
    display: block;
    top: 0;
    font-size: 14px;
    color: rgb(100, 100, 100);
    position: absolute;
    width: 100%;
    text-align: center;
    padding-top: 46px;
}

@onassar
Copy link

onassar commented Nov 13, 2020

Any update on this?

@onassar
Copy link

onassar commented Dec 18, 2020

Checking in on this.

@bherrero
Copy link

bherrero commented Jul 2, 2021

I've just run into this issue as well, both with dropbox and box. Am I missing some config to sort this out?

@Murderlon
Copy link
Member

I personally can't recreate this with a different companion domain (https://companion.uppy.io) than the client domain (localhost). If anyone can provide a reproducible example that would help moving this along.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Companion The auth server (for Instagram, GDrive, etc) and upload proxy (for S3)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants