Store token persistently, emit complete event on reconnect (if upload is complete)

[arturi]

Discussed briefly in the call, could continue here 👌

[ifedapoolarewaju]

@arturi for how long do you imagine this token be stored? To minimize the requirements (in terms of storage etc), I imagine it could be stored in session, and it would hence, disappeared when the session is expired. Does this work for the desired feature?

[arturi]

Yeah, thinking. How long would that session last approximately? Wasn’t able to quickly find a cookie to check. We are using https://www.npmjs.com/package/express-session and RedisStore, right?

[arturi]

cookie.expires
Specifies the Date object to be the value for the Expires Set-Cookie attribute. By default, no expiration is set, and most clients will consider this a "non-persistent cookie" and will delete it on a condition like exiting a web browser application.

[ifedapoolarewaju]

How long the session lasts can be configurable by any uppy-server user. Even though not yet implemented, the standalone server would pick up the session expiry time from environment variables.

Ideally uppy-server is not concerned with setting up the sessions, it is only dependent on it. If a user uses uppy-server as a pluggable app for example, (s)he would be in total control of the server sessions and is free to set it up however desired.

[arturi]

Yeah, makes sense. However for this RestoreFiles feature #268 I’d like the restore functionality to work for around 24 hours. Something like that.

Let’s also ask what @goto-bus-stop and @Acconut think :)

[goto-bus-stop]

Agree, I was thinking of something between 4 hours and 24 hours.

[ifedapoolarewaju]

ok, I think that can still be within the set lifetime of the session.

[Acconut]

I’d like the restore functionality to work for around 24 hours.

24hrs is a good duration, out of my head. I would consider anything below half a day too low for some edge cases :)

[ifedapoolarewaju]

@arturi I have added this feature to uppy-server. Now if you try to reconnect to the uppy server with a socket token for which an upload has been initiated, it would either continue with feeding upload progress (if upload is still on), or give a success or failure status.

The golden retriever branch doesn't seem to work with this feature out of the box. It seems it doesn't save the token on the client side yet. So instead it requests for a new token when the tab is closed and re-opened, hence, restarting the upload.

[ifedapoolarewaju]

while trying make uppy client support this feature, I noticed a race condition in my server implementation when multiple files are uploading at once. I am going to try to fix that

[ifedapoolarewaju]

I guess we might not be able to store the data in session after all

[ifedapoolarewaju]

I have fixed this issue

[arturi]

🎉