[2.0] aws-s3-multipart does not retry prepareUploadParts requests

[anark]

When using aws-s3-multipart with uppy 2.0 if a prepareUploadParts request fails due to a network hiccup or any other reason(Failed to fetch)
The upload stalls and never tries to continue.

We should be able to retry these requests as well as the actual uploads. Is there anyway to allow these requests to be retried?

[Murderlon]

@mifi @martin-brennan do you feel retrying prepareUploadParts makes sense for aws-s3-multipart?

[martin-brennan]

@Murderlon this is quite a timely issue. I am about to experiment more with the multipart upload functionality to see how it handles large (multi-GB) files, and last week at Discourse we discussed internally the need for retrying prepareUploadParts and each individual part upload to retry on failure.

Since each part is already retryable, I think it makes sense to make prepareUploadParts retryable as well. It would be quite frustrating to upload a multi-GB file which then fails on the final prepareUploadParts request to get the last 5 URLs needed to complete the upload.

I can take on this work if you'd like, since we need it as well?

[mifi]

As far as I can tell prepareUploadParts is just a GET that calls a pure function. It doesn't change any state, it just creates cryptographically signed URLs. So I don't see any reason why it cannot be retryable 👍

[Murderlon]

Alright! @martin-brennan if you would like to pick this up that would be great as you're most familiar :)

[Murderlon]

This issue may or may not be related to the code you are touching: #3191

[martin-brennan]

Great thanks @Murderlon, I will start work on this soonish.

[martin-brennan]

@Murderlon I am actually going on holiday for 3 weeks the week after next and I am not sure I will get to this before I go. Is it okay if I pick this up on the week of the 18th of October or is this more urgent?

[Murderlon]

@Murderlon I am actually going on holiday for 3 weeks the week after next and I am not sure I will get to this before I go. Is it okay if I pick this up on the week of the 18th of October or is this more urgent?

Thanks again for showing interest in contributing to this. I'll discuss this with the team on Monday and let you know if we rather pick this up ourselves sooner.