-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy playground into website vs separate S3 bucket #35
Comments
Actually guys - does it make sense to store |
However, we only deploy |
I'm currently leaning towards screwing that usecase as I think this is pretty great to have: http://uppyjs.io/examples/index.html If testing other branches requires running a command locally - so be it. (?) |
I've made up my mind and want the examples inside the website for all to play with. @hedgerh May I ask you to take care of this? If you just |
Sounds good |
Excellent 👍 Just to be clear: The website is already automatically deployed to gh-pages by https://github.com/transloadit/uppy/blob/master/.travis.yml#L19. That means this separete s3 bucket thing can be removed once examples work inside the website: https://github.com/transloadit/uppy/blob/master/.travis.yml#L26 |
This is how it works now, right? Reopen if I’m wrong. |
👍 |
No description provided.
The text was updated successfully, but these errors were encountered: