Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy playground into website vs separate S3 bucket #35

Closed
kvz opened this issue Nov 28, 2015 · 8 comments
Closed

Deploy playground into website vs separate S3 bucket #35

kvz opened this issue Nov 28, 2015 · 8 comments

Comments

@kvz
Copy link
Member

kvz commented Nov 28, 2015

No description provided.

@kvz
Copy link
Member Author

kvz commented Nov 28, 2015

Actually guys - does it make sense to store examples directly inside ./website? Then we get a local webserver, nice layout, deploys to GH pages, and no copying of files around for free.

@kvz
Copy link
Member Author

kvz commented Nov 28, 2015

However, we only deploy master. So we would not be able to easily preview different branches online ...

@kvz
Copy link
Member Author

kvz commented Nov 28, 2015

However, we only deploy master. So we would not be able to easily preview different branches online ...

I'm currently leaning towards screwing that usecase as I think this is pretty great to have: http://uppyjs.io/examples/index.html

If testing other branches requires running a command locally - so be it. (?)

@kvz
Copy link
Member Author

kvz commented Nov 30, 2015

I've made up my mind and want the examples inside the website for all to play with. @hedgerh May I ask you to take care of this?

If you just make website-preview, you can open http://0.0.0.0:4000/examples/dropbox.html for instance to try and get the Dropbox example to work there?

@hedgerh
Copy link
Contributor

hedgerh commented Nov 30, 2015

Sounds good

@kvz
Copy link
Member Author

kvz commented Nov 30, 2015

Excellent 👍 Just to be clear: The website is already automatically deployed to gh-pages by https://github.com/transloadit/uppy/blob/master/.travis.yml#L19.

That means this separete s3 bucket thing can be removed once examples work inside the website: https://github.com/transloadit/uppy/blob/master/.travis.yml#L26

@kvz kvz modified the milestone: Minimum Viable Product Dec 15, 2015
@arturi
Copy link
Contributor

arturi commented Dec 21, 2015

This is how it works now, right? Reopen if I’m wrong.

@arturi arturi closed this as completed Dec 21, 2015
@kvz
Copy link
Member Author

kvz commented Dec 21, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants