Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript error #5053

Closed
2 tasks done
talgat-ruby opened this issue Apr 1, 2024 · 4 comments
Closed
2 tasks done

Typescript error #5053

talgat-ruby opened this issue Apr 1, 2024 · 4 comments
Labels

Comments

@talgat-ruby
Copy link

Initial checklist

  • I understand this is a bug report and questions should be posted in the Community Forum
  • I searched issues and couldn’t find anything (or linked relevant results below)

Link to runnable example

No response

Steps to reproduce

Run the tsc check for @UPPY dashboard.

Expected behavior

Should finish successfully

Actual behavior

node_modules/@uppy/dashboard/src/utils/getFileTypeIcon.tsx(1,1): error TS6133: 'h' is declared but its value is never read.
@talgat-ruby talgat-ruby added the Bug label Apr 1, 2024
@Murderlon
Copy link
Member

Hi, can you give us a reproducible example on StackBlitz or CodeSandbox? This issue is not actionable at the moment.

@Murderlon
Copy link
Member

Murderlon commented Apr 2, 2024

Some templates:

@talgat-ruby
Copy link
Author

Hi, can you give us a reproducible example on StackBlitz or CodeSandbox? This issue is not actionable at the moment.

Thank you, @Murderlon!

Turns out I've been importing getFileTypeIcon. Because it would generate icon for my custom dashboard. And during typescript check it would also check your files.

Here is the reproducible example: https://stackblitz.com/edit/vitejs-vite-mzaxtt?file=src%2FApp.tsx

@talgat-ruby
Copy link
Author

Fixed the issue with importing from "./lib" instead of "./src". I will close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants