Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

req: remove app name from toolbar on macOS #2888

Closed
hab0bi opened this issue Apr 6, 2022 · 4 comments
Closed

req: remove app name from toolbar on macOS #2888

hab0bi opened this issue Apr 6, 2022 · 4 comments
Labels
good first issue For people who'd like to start contributing pr welcome scope:mac type:ui

Comments

@hab0bi
Copy link

hab0bi commented Apr 6, 2022

Can you please delete the app name from the toolbar? It makes the rest of the buttons evanesce:
window

@ckerr ckerr changed the title Delete app name Remove app name from toolbar on macOS Apr 6, 2022
@ckerr ckerr changed the title Remove app name from toolbar on macOS req: remove app name from toolbar on macOS Apr 7, 2022
@killemov
Copy link

killemov commented Apr 7, 2022

Can you please delete the app name from the toolbar? It makes the rest of the buttons evanesce:

... with my small window width. (Right?) IMHO it's the design decision to merge the widow title and the toolbar that is at fault here. The most important button should be at the most left and the least important button at the most right side.

@ghost
Copy link

ghost commented Apr 17, 2022

I haven't inspected the macosx code yet, but something like

if(@available(macOS 11.0, *)) {
  [mainWindow setStyleMask:NSWindowStyleMaskBorderless];
}

in the right spot should solve your problem. We also want to make sure the main window explicitly reports that it can be a key and main window.

I may try to make a patch for this, but I'm still on 10.15, so I have no reliable way to test the behavior of the new "unified" toolbar present in 11.0 and later versions. Also note that this approach will require Xcode version at least 9, which means building will only work on versions 10.12 and later. Given that Transmission still builds on version 10.10, this approach will become a bit more ugly unless we want to drop at least two entire versions of macOS.

Overall, I think the simplest approach to this problem would be to just resize your window. It looks pretty tiny in the picture.

@ckerr ckerr added pr welcome good first issue For people who'd like to start contributing type:ui labels Jun 12, 2022
@GaryElshaw
Copy link
Contributor

A quick fix. if you open the MainMenu.xib in Xcode, you can uncheck the title.

mainmenuxib

@Coeur
Copy link
Collaborator

Coeur commented Oct 19, 2022

Fixed in #3919.

@Coeur Coeur closed this as completed Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue For people who'd like to start contributing pr welcome scope:mac type:ui
Development

No branches or pull requests

5 participants