Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icons not installed with qt enabled and gtk disabled #5173

Open
floppym opened this issue Mar 7, 2023 · 3 comments
Open

Icons not installed with qt enabled and gtk disabled #5173

floppym opened this issue Mar 7, 2023 · 3 comments
Labels
bug confirmed pr welcome scope:qt type:build Changes that affect the build system

Comments

@floppym
Copy link
Contributor

floppym commented Mar 7, 2023

What is the issue?

Configuring transmission with -DENABLE_QT=ON and -DENABLE_GTK=OFF results in transmission.svg not being installed.

This causes the application launcher (transmission-qt.desktop) to show up without an icon.

Which application of Transmission?

Qt app on Linux, BSD, etc.

Which version of Transmission?

4.0.1
@GaryElshaw
Copy link
Contributor

@ckerr This might solve the mystery of why pacman on Arch is doing what it's doing #5142

@ckerr ckerr added scope:qt type:build Changes that affect the build system bug confirmed labels Mar 12, 2023
@ckerr
Copy link
Member

ckerr commented Mar 12, 2023 •
edited

Confirmed. Here is the GTK/CMakeLists.txt code that installs icons when the GTK client is enabled. There's nothing similar in qt/CmakeLists.

@floppym
Copy link
Contributor Author

floppym commented Mar 12, 2023

Would it make sense to move the icons to a common source directory that can be shared by both the gtk and qt clients?

Currently the qt directory contains an older set of icons than gtk; gtk had its icons updated in #1141.

@mrbass21 mrbass21 mentioned this issue Mar 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug confirmed pr welcome scope:qt type:build Changes that affect the build system
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ckerr @floppym @GaryElshaw