Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Pooling Layers #2

Closed
GenghuiQu opened this issue Nov 10, 2021 · 3 comments
Closed

Add Pooling Layers #2

GenghuiQu opened this issue Nov 10, 2021 · 3 comments

Comments

@GenghuiQu
Copy link

GenghuiQu commented Nov 10, 2021 •
edited
Loading

Would be better to be able to add pooling in the layers, like MaxPool2D.
@djl11 djl11 changed the title Feature Request Add Pooling Layers Nov 15, 2021
@djl11
Copy link
Contributor

djl11 commented Nov 15, 2021 •
edited
Loading

Thanks for your helpful observations!

Regarding your second point, I believe this is only an issue with the latest PyPI release. A unit test has been added for this demo in master. The PyPI release will be updated soon, thanks for pointing this out :)

Regarding the issue with jupyter notebook, does the issue appear simply when calling import ivy.tensorflow?

@djl11
Copy link
Contributor

djl11 commented Nov 15, 2021

Could you also please create separate issues for the "Quick Start" issue and the Jupyter notebook issue? I can then close these issues individually once they have been resolved. Thanks!

@GenghuiQu
Copy link
Author

Could you also please create separate issues for the "Quick Start" issue and the Jupyter notebook issue? I can then close these issues individually once they have been resolved. Thanks!

Done!

Regarding the issue with jupyter notebook, it's my fault - I didn't add 'ivy.unset_framework()' after running in PyTorch, so something went wrong when running in tensorflow. Sorry for that!

@djl11 djl11 reopened this Nov 25, 2021
@djl11 djl11 added Ivy Frontend Permanent Not to be closed, i.e. an ever evolving ToDo list. and removed Permanent Not to be closed, i.e. an ever evolving ToDo list. labels Jan 19, 2022
simonetgordon added a commit that referenced this issue Jun 14, 2022
@simonetgordon
Create test-docstrings.yml #2
5eb5c42
simonetgordon added a commit that referenced this issue Jun 14, 2022
@simonetgordon
Create test-docstrings.yml (GitHub Action)
cd79859 
Create test-docstrings.yml #2 (#1434)
juliagsy added a commit that referenced this issue Jun 14, 2022
@juliagsy
PR dashboard automation #2 (#1437)
c49f4ac
@simonetgordon simonetgordon mentioned this issue Jun 17, 2022
Merged
@djl11 djl11 closed this as completed Jul 29, 2022
bsovdat added a commit to bsovdat/ivy that referenced this issue Sep 1, 2022
@bsovdat
Update test_non_linear_activation_functions.py
28bd93a 
resolving issues ivy-llc#2
MrZilinXiao added a commit to MrZilinXiao/ivy that referenced this issue Sep 7, 2022
@MrZilinXiao
add docstring ivy-llc#2
f3b30ca
RickSanchezStoic added a commit that referenced this issue Sep 20, 2022
@RickSanchezStoic @Daniel4078 @MrZilinXiao
Fix module stateful submodule (#3651)
3dca363 
* inital changes

* changes

* changes

* changes

* changes

* changes

* fix formatting for test_modules

* changes

* fix some formatting errors for our new tests

* added docstrings for most but not all methods

* add basic docstring outlines for all functions in module.py, need descriptions for functions, arguments and retursn

* docstring add #1
(Need discussion) and (TODO) flags added for further discussion

* add docstring #2

* add separation of positional-only arguments and keyword-only arguments

* fix syntax error of module.py

* changes and fixes

* fixes

* lint fixes

* changes

* changes

* changes

* changes;

* conftest update deadline

* changes made as requested

* changes:

Co-authored-by: Rishabh Kumar <rishabhkkumarsc1@gmail.com>
Co-authored-by: Daniel4078 <45633544+Daniel4078@users.noreply.github.com>
Co-authored-by: Zilin Xiao <xiaozilin1@gmail.com>
MuhammedAshraf2020 pushed a commit to MuhammedAshraf2020/ivy that referenced this issue May 3, 2023
@rush2406
Fix tests (ivy-llc#2)
79c7c6d 
* replace calls with fw

* removed call

* added param

* changed dev_str to device

* replaced test calls to fw

* handle positional and keyword args

* handle positional and keyword args

* changed fourier_encode

* undo change
rubada added a commit to rubada/ivy that referenced this issue May 3, 2023
@rubada
resolve conflict ivy-llc#2
30cbca1
KareemMAX pushed a commit that referenced this issue Aug 21, 2023
@root-yash
Merge pull request #2 from root-yash/main
194c1bb 
remove constraint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@djl11 @GenghuiQu