Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Anime BD Tier 08 - Groups are not matched #1695

Closed
2 of 20 tasks
RedDevilGiant opened this issue Dec 22, 2023 · 6 comments
Closed
2 of 20 tasks

[Bug] Anime BD Tier 08 - Groups are not matched #1695

RedDevilGiant opened this issue Dec 22, 2023 · 6 comments
Assignees
Labels
Area: Anime Relating to Radarr/Sonarr Anime Area: Radarr Radarr Related Area: Sonarr Sonarr Related Area: Starr Custom Formats Issue is related to custom formats Status: Confirmed The issue has been confirmed Type: Bug Found a BUG/Error in the Guide

Comments

@RedDevilGiant
Copy link

RedDevilGiant commented Dec 22, 2023

Guide Name

  • Bazarr
  • Downloaders/Deluge
  • Downloaders/NZBGet
  • Downloaders/Qbittorrent
  • Downloaders/ruTorrent
  • Downloaders/SABnzbd
  • Downloaders/Other
  • Guide-Sync
  • Hardlinks/Docker
  • Hardlinks/Dockstarter
  • Hardlinks/Native
  • Hardlinks/Synology
  • Hardlinks/TrueNAS-Core
  • Hardlinks/Unraid
  • Misc
  • Plex
  • Prowlarr
  • Radarr
  • Sonarr
  • Other

Description

This Specifically pertains to the "Collection of Custom Formats" in the "Sonarr v4 Beta" guide

Groups are not matched to the groups listed in the custom format, therefore, files are not given the correct custom format score and Sonarr will incorrectly ignore them for acquiring

Examples that I have seen are: "EMBER", "Judas"

image
image

Expected Behavior

the expected behavior would be that a Group is matched to the group listed in the custom format, this will result in a particular custom format score.
this should result in Sonarr correctly deciding whether to acquire a file or not

Examples are (amongst others): "Subsplease", "VARYG"

image
image

Screenshots

No response

Additional Context

I've compared the RegEx pattern for EMBER and Judas with other groups in every list, there seem to be more that are formatted in the same way.

I've also checked the pattern on http://regexstorm.net/tester and found that the pattern for ex. EMBER does not result in a match, while the pattern for Subsplease does result in a match.

image image

I am no programmer and I barely understand this RegEx stuff so I could really use some expert help with this.

@RedDevilGiant RedDevilGiant added Status: Triage Needed New Issue Requiring Triage Type: Bug Found a BUG/Error in the Guide labels Dec 22, 2023
@FonduemangVI FonduemangVI added Status: Confirmed The issue has been confirmed Area: Sonarr Sonarr Related Area: Starr Custom Formats Issue is related to custom formats Area: Anime Relating to Radarr/Sonarr Anime Area: Radarr Radarr Related and removed Status: Triage Needed New Issue Requiring Triage labels Dec 23, 2023
@FonduemangVI
Copy link
Contributor

FonduemangVI commented Dec 23, 2023

I can confirm that it is matching on other Ember releases
image

@FonduemangVI
Copy link
Contributor

image

@FonduemangVI
Copy link
Contributor

Can you post the full filename for the EMBER release please

@rg9400
Copy link
Contributor

rg9400 commented Dec 23, 2023

The issue is due to the fact that EMBER and Judas are in the BD Tiers. They will only match bluray releases and not web releases. We did not include them in web releases as we did not believe they deserved placement in any of the tiers to be honest.

@RedDevilGiant
Copy link
Author

Can you post the full filename for the EMBER release please

Original name: [EMBER] Tokyo Revengers S03E11 [1080p] [HEVC WEBRip] (Tokyo Revengers: Tenjiku-hen)
Original File name: [EMBER] Tokyo Revengers S3 - 11.mkv
Current filename: Tokyo Revengers (2021) - S03E11 - 048 - Nothing is left [WEBRip-1080p][10bit][x265][AAC 2.0][JA]-EMBER.mkv
image

The issue is due to the fact that EMBER and Judas are in the BD Tiers.

ah, so if I understand correctly, the Regular expression matches them correctly but they aren't matched to the correct Tier.

They will only match bluray releases and not web releases.

Okay, so how can I Index them when they do release a web release?
Can I make a 7th Web Tier that contains them and give that a lower score than Web tier 6 (or maybe match the score to BD tier 08)?
does it generate conflicts if they are in multiple tiers?

We did not include them in web releases as we did not believe they deserved placement in any of the tiers to be honest.

Is their quality that bad?
I wouln't call myself an Anime Connoisseur but I didn't notice any major issues with their releases
also AniDB doesn't think that they are that bad: https://anidb.net/anime/17969

@FonduemangVI
Copy link
Contributor

The issue is due to the fact that EMBER and Judas are in the BD Tiers. They will only match bluray releases and not web releases. We did not include them in web releases as we did not believe they deserved placement in any of the tiers to be honest.

Ah thanks RG I totally glossed over that fact

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Anime Relating to Radarr/Sonarr Anime Area: Radarr Radarr Related Area: Sonarr Sonarr Related Area: Starr Custom Formats Issue is related to custom formats Status: Confirmed The issue has been confirmed Type: Bug Found a BUG/Error in the Guide
Projects
None yet
Development

No branches or pull requests

3 participants