Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential error in nuscenes_dataset #226

Open
willyd opened this issue Jun 4, 2019 · 3 comments
Open

Potential error in nuscenes_dataset #226

willyd opened this issue Jun 4, 2019 · 3 comments

Comments

@willyd
Copy link

willyd commented Jun 4, 2019

Hi,

@traveller59 Thanks for making this code available.

Could you please confirm that the behavior of this line is intended?

It looks like your are using the timestamp in place of the intensity. Is that correct? I think it should be

points = np.concatenate(sweep_points_list, axis=0)[:, [0, 1, 2, 3]]
@cvnerds
Copy link

cvnerds commented Jun 6, 2019

In the nuScenes paper not only d they write about the dataset, but also an idea to use points from multiple sweeps in order to . For instance tracking a moving point cloud solves the orientation and front/back ambiguities. It appears this could potentially be learned end-to-end simply by providing those timestamps.

@yinjunbo
Copy link

yinjunbo commented Aug 1, 2019

@willyd I agree with you. The usage of the timestamp and the intensity should be not contradictory. The author use points = np.concatenate(sweep_points_list, axis=0)[:, [0, 1, 2, 4]], but not points = np.concatenate(sweep_points_list, axis=0)[:, [0, 1, 2, 3]], which is confusing.

@pyun-ram
Copy link

@cvnerds Thanks for your answer. The use of timestamps as features can be considered as training moving point clouds.
But I still have a concern such an operation will also cause the overfitting of this dataset in an unreasonable manner.
as #254 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants