Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add llvm-toolchain-trusty-7 to the whitelist. #386

Closed
Kangz opened this issue Aug 27, 2018 · 11 comments
Closed

Please add llvm-toolchain-trusty-7 to the whitelist. #386

Kangz opened this issue Aug 27, 2018 · 11 comments

Comments

@Kangz
Copy link

Kangz commented Aug 27, 2018

LLVM just branched version 7 to a different APT repo. Please add it to the whitelist!

It is defined on apt.llvm.org.

  {
    "alias": "llvm-toolchain-trusty-7",
    "sourceline": "deb http://apt.llvm.org/trusty/ llvm-toolchain-trusty-7 main",
    "key_url": "http://apt.llvm.org/llvm-snapshot.gpg.key"
  },
Kangz added a commit to Kangz/dawn that referenced this issue Aug 27, 2018
LLVM 7.0 was branched from ToT because it is going to be released soon.
This means that the repo we use to get clang-format now is LLVM 8.0 so
we update to clang-format-8.

We cannot add the LLVM 7.0 specific repo because it isn't in the Travis
APT source whitelist yet. Opened an issue to add to the whitelist:
travis-ci/apt-source-safelist#386

Change-Id: I30b1cbf3ab5567bfa7fa3073e27eee5fcf3d1785
Kangz added a commit to Kangz/dawn that referenced this issue Aug 27, 2018
LLVM 7.0 was branched from ToT because it is going to be released soon.
This means that the repo we use to get clang-format now is LLVM 8.0 so
we update to clang-format-8.

We cannot add the LLVM 7.0 specific repo because it isn't in the Travis
APT source whitelist yet. Opened an issue to add to the whitelist:
travis-ci/apt-source-safelist#386

Change-Id: I30b1cbf3ab5567bfa7fa3073e27eee5fcf3d1785
Kangz added a commit to googlearchive/nxt-standalone that referenced this issue Aug 27, 2018
LLVM 7.0 was branched from ToT because it is going to be released soon.
This means that the repo we use to get clang-format now is LLVM 8.0 so
we update to clang-format-8.

We cannot add the LLVM 7.0 specific repo because it isn't in the Travis
APT source whitelist yet. Opened an issue to add to the whitelist:
travis-ci/apt-source-safelist#386

Change-Id: I30b1cbf3ab5567bfa7fa3073e27eee5fcf3d1785
@pavelkryukov
Copy link

"sourceline": "deb http://apt.llvm.org/trusty/ llvm-toolchain-trusty-6 main",

Do you mean "sourceline": "deb http://apt.llvm.org/trusty/ llvm-toolchain-trusty-7 main",?

@Kangz
Copy link
Author

Kangz commented Aug 30, 2018

Yes, edited it.

@Kangz
Copy link
Author

Kangz commented Sep 1, 2018 via email

@concatime
Copy link

Up.

1 similar comment
@akimd
Copy link

akimd commented Sep 23, 2018

Up.

@PragmaTwice
Copy link

PragmaTwice commented Sep 24, 2018

Up.
I wanna clang-7.0 in llvm-toolchain-trusty-7, please.

@offa
Copy link

offa commented Sep 26, 2018

There's a pending PR now: #392

@sylvestre
Copy link
Contributor

It landed. This bug can be closed.

@Kangz Kangz closed this as completed Oct 6, 2018
@psi29a
Copy link

psi29a commented Nov 8, 2018

Still getting:

Adding APT Sources
Disallowing sources: llvm-toolchain-trusty-7.0
To add unlisted APT sources, follow instructions in https://docs.travis-ci.com/user/installing-dependencies#Installing-Packages-with-the-APT-Addon

@pavelkryukov
Copy link

pavelkryukov commented Nov 8, 2018

@psi29a They changed spelling, it is llvm-toolchain-trusty-7 now, without a dot-zero

@psi29a
Copy link

psi29a commented Nov 8, 2018

Cheers! Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants