Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dpl 1.9.0 issue #778

Closed
BenFradet opened this issue Mar 12, 2018 · 7 comments
Closed

dpl 1.9.0 issue #778

BenFradet opened this issue Mar 12, 2018 · 7 comments
Assignees
Labels

Comments

@BenFradet
Copy link

BenFradet commented Mar 12, 2018

We've recently started seeing failure during deploys because of dpl, e.g.:

$ rvm $(travis_internal_ruby) --fuzzy do ruby -S gem install dpl
Successfully installed dpl-1.9.0
1 gem installed
dpl.1
Installing deploy dependencies
LoadError: no such file to load -- dpl/provider/script
       require at org/jruby/RubyKernel.java:959
       require at /home/travis/.rvm/rubies/jruby-9.1.6.0/lib/ruby/stdlib/rubygems/core_ext/kernel_require.rb:55
  block in new at /home/travis/.rvm/gems/jruby-9.1.6.0/gems/dpl-1.9.0/lib/dpl/provider.rb:72
          fold at /home/travis/.rvm/gems/jruby-9.1.6.0/gems/dpl-1.9.0/lib/dpl/cli.rb:41
           new at /home/travis/.rvm/gems/jruby-9.1.6.0/gems/dpl-1.9.0/lib/dpl/provider.rb:66
           run at /home/travis/.rvm/gems/jruby-9.1.6.0/gems/dpl-1.9.0/lib/dpl/cli.rb:31
           run at /home/travis/.rvm/gems/jruby-9.1.6.0/gems/dpl-1.9.0/lib/dpl/cli.rb:7
        <main> at /home/travis/.rvm/gems/jruby-9.1.6.0/gems/dpl-1.9.0/bin/dpl:5
          load at org/jruby/RubyKernel.java:977
        <main> at /home/travis/.rvm/gems/jruby-9.1.6.0/bin/dpl:22
failed to deploy

https://travis-ci.org/snowplow/snowplow/jobs/352410746#L2870

It might be linked to the jruby version we're using?

@BanzaiMan
Copy link
Contributor

I see. Looks like JRuby's error message does not match MRI's, so we are not installing the provider gem.

@BanzaiMan BanzaiMan self-assigned this Mar 12, 2018
@BanzaiMan
Copy link
Contributor

Actually… Why is this build using JRuby to deploy? It should be using MRI.

@BenFradet
Copy link
Author

We've had to reinstall rvm manually because of travis-ci/travis-ci#8717, maybe this is linked?

@BanzaiMan
Copy link
Contributor

Could you add these commands anywhere before the deployment?

rvm list strings
echo $(travis_internal_ruby)

Thanks.

@BanzaiMan BanzaiMan added the bug label Mar 12, 2018
@BenFradet
Copy link
Author

 before_deploy:
  - rvm list strings
  - echo $(travis_internal_ruby)

gives back:

$ rvm list strings
jruby-9.1.6.0
$ echo $(travis_internal_ruby)
default

@BanzaiMan
Copy link
Contributor

I see. You have only JRuby installed via RVM and it is the version we are choosing.

I now also see that you are running rvm implode (https://travis-ci.org/snowplow/snowplow/jobs/352410746#L615) and destroying the deployment capability. Please consider not doing that.

For the time being, please install a Ruby > 2.2.

@BenFradet
Copy link
Author

 before_deploy:
  - rvm install 2.4.3
  - rvm --default use 2.4.3

fixed it, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants