Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow provider s3 to set custom metadata headers #898

Closed
nikhilo opened this issue Dec 12, 2016 · 5 comments
Closed

Allow provider s3 to set custom metadata headers #898

nikhilo opened this issue Dec 12, 2016 · 5 comments

Comments

@nikhilo
Copy link

nikhilo commented Dec 12, 2016

This requirement is due to the behavior of S3 multi part upload. Where the E-tag of the uploaded artifact isn't a straight md5sum of the file. It's calculated based on md5sum of each of the parts (in multi-part).

So, when downloading the artifact deployed by travis, we cannot verify the artifact's md5sum with the existing file's md5sum (if the file already exists). This results in re-downloading of the file even if the same file exists (which is every chef-client run).

To work around this problem, we have been suggested to use a custom metadata header set to the actual md5sum while uploading the file to S3. Unfortunately, there is no way in Travis to set custom x-amz-meta-* headers. Is it something that can be provided?

@PhilGuay
Copy link

+1

1 similar comment
@tt-sergey
Copy link

+1

@travis-ci travis-ci locked and limited conversation to collaborators Dec 12, 2016
@BanzaiMan
Copy link
Contributor

Please refrain from +1's. There are other ways to express your desire for the feature proposed.

@travis-ci travis-ci unlocked this conversation Nov 3, 2018
@BanzaiMan BanzaiMan transferred this issue from travis-ci/travis-ci Nov 3, 2018
@travis-ci travis-ci locked and limited conversation to collaborators Nov 3, 2018
@travis-ci travis-ci unlocked this conversation Aug 19, 2019
@svenfuchs
Copy link
Contributor

@nikhilo @PhilGuay @tt-sergey i would like to give this a shot in dpl v2, but i am not quite sure i understand how this should be implemented.

do i understand this right that it would be sufficient to a flag --custom-headers that takes any string x-amz-meta-[key]=[value] and passes this on as a header with the given name and value?

(if so, obviously we'd want to allow passing multiple such headers, i.e. using an array in .travis.yml).

@stale
Copy link

stale bot commented Nov 17, 2019

Thanks for contributing to this issue. As it has been 90 days since the last activity, we are automatically closing the issue. This is often because the request was already solved in some way and it just wasn't updated or it's no longer applicable. If that's not the case, please do feel free to either reopen this issue or open a new one. We'll gladly take a look again! You can read more here: https://blog.travis-ci.com/2018-03-09-closing-old-issues

@stale stale bot added the stale label Nov 17, 2019
@stale stale bot closed this as completed Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants