Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User sync drops permissions if GH request failed #2170

Closed
sarahhodne opened this issue Apr 16, 2014 · 1 comment
Closed

User sync drops permissions if GH request failed #2170

sarahhodne opened this issue Apr 16, 2014 · 1 comment

Comments

@sarahhodne
Copy link
Contributor

Occasionally the GH requests fail in gatekeeper. Since all permissions are dropped before this, this means that all repositories will "disappear" for a user until the next sync 24 hours later.

We should probably add a retry of some sort, or wait with dropping the permission until the request succeeded.

(By "failing" requests here I mean in the "could not connect to server" sense. I also saw a null pointer exception in the logs related to the request.)

@sarahhodne sarahhodne changed the title User sync drops repositories if GH request failed User sync drops permissions if GH request failed Apr 29, 2014
@BanzaiMan
Copy link
Contributor

The latter approach seems reasonable.

@svenfuchs svenfuchs self-assigned this Jun 16, 2014
@joshk joshk closed this as completed Jul 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants