Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting emails for other people's forks #280

Closed
schof opened this issue Oct 6, 2011 · 2 comments
Closed

Getting emails for other people's forks #280

schof opened this issue Oct 6, 2011 · 2 comments

Comments

@schof
Copy link

schof commented Oct 6, 2011

Just got a notification that cmaujean/spree passed. I'm not a manager of this project so I should not get emails every time someone gets their Travis-CI build working for a spree fork.

We discussed this today in #spree. Unfortunately its not an isolated incident - this is the second time today.

@chrisharper
Copy link

The issue is here : https://github.com/travis-ci/travis-ci/blob/master/app/models/build/notifications.rb#L89

Github api provides some attributes we can check against to see if the repo is a fork : fork,source,parent

The issue Is calculating if the commit received is unique to the forked repository or originally from the parent applied to the fork.

Without looking up the commit ref on the parent fork I can see no other solution.

There is also the issue of someone taking commits from other forks (not the parent) and applying them to there fork which would also send off an email.

@martinciu martinciu mentioned this issue Oct 29, 2011
@michaelklishin
Copy link
Contributor

After several discussions about possible solutions, it looks like there is no solution where downsides do not outweight the upsides or potentially make email notification logic even more confusing than it is today. Closing, maybe some day there will be a better solution for forks and notifications in general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants