Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notifications.webhooks.on_start should accept values true and false #52

Open
thomasleveil opened this issue Feb 22, 2015 · 0 comments
Open

Comments

@thomasleveil
Copy link

It is documented that the webhooks option on_start can have true or false as value. From the travis-core project, it seems that on_start accepts the documented value true but also the undocumented value always.

Currently the linter warns for using values true or false and guides us to use either always, changed or never as in the SPEC.md file.


when testing

language: ruby
notifications:
  webhooks:
    urls: http://echo.jsontest.com
    on_start: true  # or false

actual result

in notifications.webhooks section: dropping on_start section: illegal value true

expected result

Hooray, your .travis.yml seems to be solid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant