Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Snappy compression #2

Open
travisbrown opened this issue Jan 20, 2022 · 1 comment
Open

Support Snappy compression #2

travisbrown opened this issue Jan 20, 2022 · 1 comment

Comments

@travisbrown
Copy link
Owner

This should be pretty easy to add, probably via this Rust library.

At a glance there are a couple of issues I see:

  1. I'm not sure whether ORC uses the Snappy frame format or just the raw encoded bytes.
  2. Unlike the Zlib and Zstandard decoders I'm using now, snap::read::FrameDecoder doesn't provide an into_inner to take back ownership of the reader, which means we might have to adjust a few things higher up in the implementation here.

I don't need this so it probably won't get worked on, but it'd be nice to have.

@travisbrown
Copy link
Owner Author

Note that I've added a Snappy example, so basic tests for Snappy support will be easy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant