Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider information for the separator usage with the CSV output format #452

Open
elfring opened this issue Sep 10, 2022 · 2 comments
Open

Comments

@elfring
Copy link

elfring commented Sep 10, 2022

Different information was published.

  1. 2017-02-04: Implementation of the function “csv_close”

    mtr/ui/report.c

    Line 464 in 5c8cc17

    printf("Mtr_Version,Start_Time,Status,Host,Hop,Ip,");
  2. 2015-06-29: manual

    mtr/mtr.8

    Line 223 in 7f2d11e

    (Note: The separator is actually a semi-colon ';'.)

How would you like to fix this situation? 🤔

@rewolff
Copy link
Collaborator

rewolff commented Sep 11, 2022

The easiest fix is to remove the note.
For those using mtr in scripts in the csv mode, it would be annoying to change it to follow the documentation.

In many cases, other separators are useful. e.g. when I export a bill-of-materials for a PCB design it will list 100nF, 0805, "C1, C2, C3" But although spreadsheets know how to parse that, it is difficult for "awk". So using semicolons because data can include commas is useful. I don't think the data can include commas in mtr output, so using a semicolon is not very useful.

If you want to change the code anyway, I suggest you allow to set it using an option and make the default a comma.

@elfring
Copy link
Author

elfring commented Sep 11, 2022

I don't think the data can include commas in mtr output, …

Can such data display be adjusted according to decimal separator settings? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants