Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site is broken when viewed through github pages #7

Open
jlndk opened this issue Mar 30, 2016 · 5 comments
Open

Site is broken when viewed through github pages #7

jlndk opened this issue Mar 30, 2016 · 5 comments

Comments

@jlndk
Copy link

jlndk commented Mar 30, 2016

When i tried to view the site, through the link http://travisneilson.github.io/DevTipsShowWebsite, the website weren't styled properly.

It looked like this:
screencapture-travisneilson-com-devtipsshowwebsite-1459336768299

@andrealeone
Copy link

It is a matter of links:
you just need to remove the slash from the path to the main stylesheet for the homepage - for the other pages just add two dots at the root.

<link href="assets/css/main.css" rel="stylesheet"> and
<link href="../assets/css/main.css" rel="stylesheet">

link-fixing-one
link-fixing-two

It depends on Travis..

@andrealeone
Copy link

I'm going to "relativize" paths in a separate branch to pull.

@travisneilson
Copy link
Owner

How big of an issue is this? I didn't even consider this use case because, why would anyone go there?

@andrealeone
Copy link

Yeah, you're right.. I did't think about it. --It is still fun and a pleasure to try to fix bugs.

@jlndk
Copy link
Author

jlndk commented Apr 1, 2016

Since this website is properly going to be viewed by many of your viewers, i think it would be a good little fix, considering how little time it takes :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants