Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid cron doesn't return right error message #922

Closed
darkchilli opened this issue Nov 26, 2018 · 2 comments
Closed

Invalid cron doesn't return right error message #922

darkchilli opened this issue Nov 26, 2018 · 2 comments

Comments

@darkchilli
Copy link

Digdag v0.9.31
Issue: When pushing to digdag server from digdag-client, not returning helpful error message.

--- Dig file ---

schedule:
cron>: 1 4,8,12,16,20
...
...

--- digdag push ---
digdag push corporate -e xx.xx.xx.xx:65432
2018-11-26 10:53:46 +1100: Digdag v0.9.31
Creating .digdag/tmp/archive-8215978397101272324.tar.gz...
Archiving xxxxxxx.dig
Workflows:
xxxxxxx.dig
error: HTTP 500 Internal Server Error (internal server error)

--- Expect ---
Invalid cron error should be returned to client, at the moment it seems to be only available on digdag server side.
Digdag server log:
Caused by: it.sauronsoftware.cron4j.InvalidPatternException: invalid pattern: "1 4,8,12,16,20"

@hiroyuki-sato
Copy link
Contributor

Hello, @darkchilli

Thank you for reporting the issue.
I think It is better to report the right message when invalid format pushed.

Could you try cron>: 1 4,8,12,16,20 * * *?

@yoyama
Copy link
Contributor

yoyama commented Jul 13, 2019

I will close it, because #1026 may solve this issue. If you still have the issue feel free to reopen.

@yoyama yoyama closed this as completed Jul 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants