Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preparation for v1.0.0 release #58

Merged
merged 4 commits into from Nov 11, 2019
Merged

Preparation for v1.0.0 release #58

merged 4 commits into from Nov 11, 2019

Conversation

takuti
Copy link
Contributor

@takuti takuti commented Oct 31, 2019 •
edited

@takuti takuti changed the title [WIP] Preparation for v1.0.0 release Preparation for v1.0.0 release Nov 5, 2019
@takuti
Copy link
Contributor Author

takuti commented Nov 5, 2019

We will be releasing pytd v1.0.0 since Plazma Public API becomes GA.

@chezou Review plz 🙇

@Lewuathe Can you check if the current td_pyspark required version makes sense as a dependent package? If you're planning to release newer td_pyspark due to the Plazma API release, please let us now 🙏 https://github.com/treasure-data/pytd/blob/master/setup.py#L71

chezou
chezou reviewed Nov 7, 2019
View reviewed changes
pytd/client.py
@@ -219,6 +222,43 @@ def get_table(self, database, table):
"""
return Table(self, database, table)

def exists(self, database, table=None):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

chezou
chezou approved these changes Nov 7, 2019
View reviewed changes
Copy link
Member

@chezou chezou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Lewuathe
Lewuathe approved these changes Nov 11, 2019
View reviewed changes
Copy link

@Lewuathe Lewuathe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check if the current td_pyspark required version makes sense as a dependent package?

As there is no change in terms of the interface of plazma-public-api, we should be able to keep using the latest td-pyspark. Thus 19.9.0 makes sense to me.

LGTM

@takuti takuti merged commit 56ee632 into master Nov 11, 2019
@takuti takuti deleted the v1 branch November 11, 2019 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chezou chezou chezou approved these changes

@Lewuathe Lewuathe Lewuathe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@takuti @chezou @Lewuathe