-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fractal-Tree broken on mobile #18
Comments
Hey I didnt check out the code yet, but isnt that similar to what I have worked on? I was wondering, if you would like me to outsource and refactor my work with proper interfaces so the scaling logic can be re-used. If so, what about you create another issue for the outsourcing and assign it to me, ill take care of it. Afterwards we can go through the fractals one by one to refactor to reuse that logic. |
Sry I didn't see that. Not the most on top of things sometimes, should really enable notifications for this repo haha 😅 I like the idea, the outsourcing is already done, so now it's just a question of using that same logic to close this issue right? There is one problem I see you could run into with this approach, namely the different fractals will have different algorithms and hence you might need to figure out how to adapt the Barnsley Fern approach to new types of fractals that don't have a mapping to the idea of "furthest point left,right,up,down". Especially L-Systems could be a bit of a problem since they are just long strings executed as draw instructions one by one and the scaling happens in between iterations with some magic numbers. Let me know how it goes/if you need help 👍 |
Well I guess we need to find different ways to determine the sizes depending on the fractals. I could not really abstract for the canopy :c // I will just hit you with the @trebeljahr this time haha check out the PR at your leisure :) |
The Fractal-Tree / Fractal-Canopy doesn't show nicely on mobile. Needs some calculations to figure out the maximum Root Length based on the current settings, to stay within the bounds of the screen.
The text was updated successfully, but these errors were encountered: