Add CompanyServiceImpl Test #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @bglamadrid, Please check my changes in Changelog.md if its correct format |
bglamadrid
approved these changes
Oct 13, 2022
There was a problem hiding this comment.
Outstanding work @NyorJa 💯
I do have one minor concern, a single comment below that you may address if possible. Besides that, this is exactly what was required 👌
I will merge this PR perhaps before 6PM UTC, but not later than that.
Thank you once again!
CHANGELOG.md
Outdated
Comment on lines
9
to
11
| ### Tests | ||
| - CompanyServiceImpl - validate the proper mapping behaviour of method "readDetails" | ||
|
|
There was a problem hiding this comment.
There is a Tests section at line 34, you can move this change there
There was a problem hiding this comment.
oops..ill fix that.
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
mvn testreturns exit code 0, without errors)PR Type
Summary
Validate the proper mapping behaviour of CompanyServiceImpl method "readDetails"