Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flat node structure for else if #199

Closed
wants to merge 24 commits into from

Conversation

ribru17
Copy link
Contributor

@ribru17 ribru17 commented Mar 20, 2024

Flattens the structure for else if .... This is sort of a human convenience change, as technically an else if is just an if nested in the else clause... but this will make a nicer tree (though indentation will have to be updated e.g. in nvim-treesitter)

Fixes #198

@amaanq
Copy link
Member

amaanq commented Mar 21, 2024

Idk, this just feels incorrect overall but I understand the reasoning behind it. @maxbrunsfeld?

@amaanq
Copy link
Member

amaanq commented May 31, 2024

given the recent improvements to fetching a parent in tree-sitter and neovim, I'm closing this out

@amaanq amaanq closed this May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: flat structure for else if chain
6 participants