Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version mismatch in Makefile in 0.20.8 release #2210

Closed
msva opened this issue Apr 16, 2023 · 2 comments · Fixed by #2211
Closed

Version mismatch in Makefile in 0.20.8 release #2210

msva opened this issue Apr 16, 2023 · 2 comments · Fixed by #2211

Comments

@msva
Copy link

msva commented Apr 16, 2023

Hi there!
Makefile in 0.20.8 tag states VERSION := 0.20.9.

This looks like a mismatch.

Isn't it was supposed to be 0.20.8 at the momennt of the tag, and become 0.20.9 right after that tag, for example?

@msva
Copy link
Author

msva commented Apr 27, 2023

@ahlinc You've set version in makefile to 0.20.10, but last release is still .8
Do you plan to skip .9 and will next release be .10?

Otherwise, this version change will repeat the mismatch issue in next release (if it will be .9 with makefile stating .10)

@ahlinc
Copy link
Contributor

ahlinc commented Apr 27, 2023

I've set it to the actual version from lib's Cargo.toml, releases seen on GH releases are CLI versions and they currently may be out of sync with the core lib. This will be changed soon that the lib wouldn't have higher version than CLI and it would sync with CLI occasionally by skipping some versions without changes in the lib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants