Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-existing or outdated (?) API in the readme #9

Closed
mratsim opened this issue Feb 9, 2021 · 1 comment
Closed

Non-existing or outdated (?) API in the readme #9

mratsim opened this issue Feb 9, 2021 · 1 comment

Comments

@mratsim
Copy link

mratsim commented Feb 9, 2021

The readme has many reference to the following API

type Entry1 = object
  color: string
var s = """{"extra":"foo"}"""
var v = fromJson[Entry1](s)
doAssert v.color == ""

But the library is expecting var v = s.fromJson(Entry1)

@treeform
Copy link
Owner

treeform commented Feb 9, 2021

Fixed with b6f9d2f

Had an API change late during development forgot about readme.

Thank you for reporting the issue!

@treeform treeform closed this as completed Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants