Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show visual indicator when search node is collapsed #150

Closed
taramk opened this issue May 16, 2023 · 2 comments · Fixed by #184
Closed

Show visual indicator when search node is collapsed #150

taramk opened this issue May 16, 2023 · 2 comments · Fixed by #184
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@taramk
Copy link
Contributor

taramk commented May 16, 2023

There is currently no visual indication that a search node is collapsed; we are using the same icon as the uncollapsed version. For the collapsed version, let's put a light gray circle around the search icon like we do for standard collapsed nodes. This requires adjusting some sizing.

Changes:

  • Search icon should use the Feather icon at 1.5px stroke width
  • Search icon should always be at the size indicated in Figma (with the default Feather icon frame, the frame size is 11x11px)
  • The light gray outer circle that indicates a collapsed node should be increased in size to 15px, as indicated in the Figma link above. This outer circle size applies to a regular node as well as a search node.
  • When the outer light gray circle is applied to the search node, the search node icon should be centered within it.
@taramk taramk added this to the 0.4.0 milestone May 16, 2023
@taramk taramk changed the title Show indicator when search nodes are collapsed Show visual indicator when search node is collapsed May 16, 2023
@progrium
Copy link
Contributor

This is cool. If we can standardize this enough to make it programmatic (which there is a chance since we're using SVG) it would benefit extension components that provide these icons so they wouldn't have to create this variation, we could just make it work automatically.

@taramk
Copy link
Contributor Author

taramk commented May 16, 2023

@progrium i don't see why not. the search node icon and outer circle size should work fine as a template. i would definitely prefer it to be consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants