Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

00 AM/PM should be 12 AM/PM when time format is set to 12 hours #2

Closed
DlljsCodes opened this issue Jul 2, 2020 · 3 comments
Closed

Comments

@DlljsCodes
Copy link

DlljsCodes commented Jul 2, 2020

This happens in the time selection drop-down when entering data and in forecast screens e.g. Overview. It really threw me off when entering data, as it doesn't match how the time is shown on the in-game clock. Happens on English (UK) language setting.
image
Current settings:
image

@DlljsCodes
Copy link
Author

Works as intended on English (US)

@Treeki
Copy link
Owner

Treeki commented Jul 7, 2020

this seems to be a Chrome/Blink bug related to me using 'hour12: true' for 12-hour times rather than 'hourCycle', I've tried to work around it and am hoping it won't break behaviour on any other setups

this comment on an entirely different project shows what seems to be a variation of the same issue, Chrome showing odd times with 'hour12: false' in en-AU when Firefox and Safari produce the correct result: moment/luxon#675 (comment)

@Treeki Treeki closed this as completed Jul 7, 2020
@DlljsCodes
Copy link
Author

Confirmed working on Chrome 83, with Settings set to English (UK) and 12 hours
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants