Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check how much the bundle size is reduced by removing phosphor-icons and using .svg instead #42

Closed
lukasbals opened this issue Feb 24, 2022 · 4 comments

Comments

@lukasbals
Copy link
Member

Check how much the bundle size is reduced by removing phosphor-icons and using .svg instead. This would also imply making the icons that are used configurable

@raulsteurer
Copy link
Contributor

raulsteurer commented Mar 21, 2022

@lukasbals I have downloaded the icons as SVGs and wrapped them in Chakra UIs Icon component.

The results of running npm run size:

CommonJS ESM
Importing Icons from phosphor-react 1050kB 173kB
Importing hardcoded Icons 749kB 171kB

So just like with #66, the difference in CJS doesn't bother me.

@lukasbals
Copy link
Member Author

Interesting! So I assume your recommendation would be not to change it? 🙂

@lukasbals
Copy link
Member Author

@raulsteurer Are you fine with me closing the issue?

@raulsteurer
Copy link
Contributor

raulsteurer commented Mar 23, 2022

Interesting! So I assume your recommendation would be not to change it? 🙂

Oops, I totally missed this comment... 😄
Yes I wouldn't change it. Feel free to close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants