fix(Expandable): Center icon #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/treely/boemly/Fm2x5Zm2W2pV9PAMfcof3FBNZmZJ |
size-limit report 📦
|
lukasbals
reviewed
Apr 3, 2022
lukasbals
reviewed
Apr 3, 2022
Forget this. I thought the icon in the button on the right is meant. But now I realised that you mean the icon on the left. |
raulsteurer
force-pushed
the
rs/centericon
branch
from
b351f22
to
4f18b60
Compare
raulsteurer
force-pushed
the
rs/centericon
branch
from
a127d05
to
b11b02d
Compare
|
🎉 This PR is included in version 1.12.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, any icon would be aligned to the left top. Only square phosphor-icons with size 80 would appear centered.
This change centers all icons - or really any jsx element provided in the icon prop - vertically and horizontally in the parent div.
Before:
After:
