Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not touch the user's shell configuration #133

Open
ghost opened this issue Feb 17, 2021 · 5 comments
Open

Do not touch the user's shell configuration #133

ghost opened this issue Feb 17, 2021 · 5 comments
Labels
enhancement version:5 Breaking changes, if a version 5 gets planned

Comments

@ghost
Copy link

ghost commented Feb 17, 2021

From the docs:

Awsume will make an attempt to place this in a login script such as your ~/.bash_profile or ~/.bashrc when it's being installed, so you may need to restart your terminal or re-source your login file.

It's generally rude for applications to automatically modify a user's custom configuration, especially when using standard utilities like python-setup. Users should be expected to be able to add such functionality themselves - this is a "power tool", after all.

@imaginarynik
Copy link

Quick question: Is awsume also storing the temporary tokens in bash_profile/bashrc files?

@ghost
Copy link
Author

ghost commented Feb 19, 2021

No, it's all being put in .awsume:

[~]$ tree .awsume/
.awsume/
├── cache
│   └── aws-credentials-XXXXXXXXXXXX
└── config.yaml

@mbarneyjr
Copy link
Member

There is a way to prevent awsume from installing the alias on installation through the use of an environment variable (documented here):

AWSUME_SKIP_ALIAS_SETUP=true pipx install awsume

Unfortunately it was released as an "opt-out" as opposed to an "opt-in." Reversing that would be a breaking change, so until a possible awsume version 5, we won't be implementing this just yet

@ghost
Copy link
Author

ghost commented May 13, 2021

Wouldn't it make sense to keep this ticket open until that's implemented, then?

@mbarneyjr
Copy link
Member

Good catch, I'll tag this as version 5 and keep it open

@mbarneyjr mbarneyjr reopened this May 13, 2021
@mbarneyjr mbarneyjr added the version:5 Breaking changes, if a version 5 gets planned label May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement version:5 Breaking changes, if a version 5 gets planned
Projects
None yet
Development

No branches or pull requests

3 participants