New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for OCCT 7.6.0 #54
Comments
+1 - the build currently fails on the conda-forge feedstock for occt 7.6: conda-forge/smesh-feedstock#52 |
This would be great! Currently, it's blocking the building of FreeCAD too with the VTK 9.1.0, which is build with OCCT 7.6.0. |
thanks for feedback. i can probably get to this in the next week or so |
Hi @trelau - did you have a chance to look at this? Many thanks in advance! |
@Tobias-Fischer not yet, unfortunately. the day job has been keeping me busy lately :) |
here is the commit for freecad-internal smesh to work with occt7.6: |
I tried to work on this and applying some diff from the posted commit. But now I am stuck with this:
@wwmayer do you run into the same issue when trying to port smesh to occt7.6? |
Fails for me, too. The problem is the struct ElementsOnShape::Classifier in SMESH_Controls.cxx because it has a member variable of the type GeomAPI_ProjectPointOnSurf and that has a member of type Extrema_GenExtPS. For Extrema_GenExtPS the copy-constructor is disabled so that it's not possible to make a copy of GeomAPI_ProjectPointOnSurf and thus no copy of ElementsOnShape::Classifier. But somewhere in SMESH_Controls.cxx this is requested and thus leads to the compiler error. The trick to solve the issue is a hand-written copy-constructor of ElementsOnShape::Classifier the omits the GeomAPI_ProjectPointOnSurf member. |
Thanks, did you make these changes to the freecad internal smesh? If so can you share the commit? |
No, because it's too old and doesn't have that file. But I prepared a patch file with all my changes. It was a bit tricky to create the patch because for the build I didn't have to change the files that are under git control but a free copy. |
Thanks a lot, I will have a look in the next days. |
@trelau what is the best workflow to create the patches? |
been out of the loop for a bit now, but if i understand the question, i remember editing files, checking the patch difference in git GUI, then copy/pasting that into a patch file and trying it out locally (i think there is a python file that attempts to apply patch files). there is surely a better way to make patch files that is what i remember doing |
I got a chance to work on this project a bit and got updated to:
I have a local branch for OCCT 7.6 but I'm battling one last compiler error on windows. I'll share that branch in the next day or so. |
Branch is here https://github.com/trelau/SMESH/tree/occt76 But, failing due to one issue with "SMESH::Controls::ElementsOnShape::Classifier". one example here https://github.com/trelau/SMESH/runs/6290166835?check_suite_focus=true#step:8:737 |
https://dev.opencascade.org/content/open-cascade-technology-760-released
The text was updated successfully, but these errors were encountered: