Upgrade to RxJava 2 #167
Merged
Upgrade to RxJava 2 #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal here is just to start the big transition, I'm sure there are lots of little polishes/improvements we can do once this is in. Some of the bigger changes: - Removed dependency on RxBinding since there is no RxJava 2-based RxBinding yet. Implementing our own ViewDetachesOnSubscribe was not that bad. - Rolled all Transformers into a single LifecycleTransformer, now that we can do so (due to composition-friendly interfaces).
vanniktech
approved these changes
Nov 4, 2016
| = this.compose(RxLifecycleAndroid.bindView<T>(view)) |
There was a problem hiding this comment.
Missing extension methods for Maybe + Flowable. So far I also didn't see that support was added for those. This is just meant as a reminder.
| * {@code source.compose(RxLifecycle.bind(lifecycle)).subscribe()} | ||
| * <p> | ||
| * This helper automatically determines (based on the lifecycle sequence itself) when the source | ||
| * should stop emitting items. Note that for this method, it assumes <em>any</em> event | ||
| * emitted by the given lifecycle indicates that the lifecycle is over. | ||
| * | ||
| * @param lifecycle the lifecycle sequence | ||
| * @return a reusable {@link Observable.Transformer} that unsubscribes the source whenever the lifecycle emits | ||
| * @return a reusable {@link ObservableTransformer} that unsubscribes the source whenever the lifecycle emits |
There was a problem hiding this comment.
it returns a LifecycleTransformer
| * {@code source.compose(RxLifecycle.bindUntilEvent(lifecycle, ActivityEvent.STOP)).subscribe()} | ||
| * | ||
| * @param lifecycle the lifecycle sequence | ||
| * @param event the event which should conclude notifications from the source | ||
| * @return a reusable {@link Observable.Transformer} that unsubscribes the source at the specified event | ||
| * @return a reusable {@link ObservableTransformer} that unsubscribes the source at the specified event |
There was a problem hiding this comment.
it returns LifecycleTransformer that implements ObservableTransformer plus the one for Single + Completable
| @@ -83,16 +84,16 @@ private RxLifecycle() { | |||
| * | |||
| * @param lifecycle the lifecycle sequence | |||
| * @param correspondingEvents a function which tells the source when to unsubscribe | |||
| * @return a reusable {@link Observable.Transformer} that unsubscribes the source during the Fragment lifecycle | |||
| * @return a reusable {@link ObservableTransformer} that unsubscribes the source during the Fragment lifecycle | |||
| */ | |||
| @Nonnull | |||
| @CheckReturnValue | |||
| public static <T, R> LifecycleTransformer<T> bind(@Nonnull Observable<R> lifecycle, | |||
|
|
||
| @Override | ||
| public CompletableSource apply(Completable upstream) { | ||
| return Completable.amb( |
There was a problem hiding this comment.
maybe consider using Completable.ambArray here
|
|
||
| @Override | ||
| public CompletableSource apply(Completable upstream) { | ||
| return Completable.amb( |
There was a problem hiding this comment.
maybe consider using Completable.ambArray here
|
|
||
| @Override | ||
| public CompletableSource apply(Completable upstream) { | ||
| return Completable.amb( |
There was a problem hiding this comment.
maybe consider using Completable.ambArray here
| .compose(new UntilLifecycleTransformer<String, String>(lifecycle)) | ||
| .test(); | ||
|
|
||
| testObserver.assertNoValues(); |
Now that we have just one omni-transformer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal here is just to start the big transition, I'm sure there are
lots of little polishes/improvements we can do once this is in.
Some of the bigger changes:
Removed dependency on RxBinding since there is no RxJava 2-based
RxBinding yet. Implementing our own ViewDetachesOnSubscribe was
not that bad.
Rolled all Transformers into a single LifecycleTransformer, now that
we can do so (due to composition-friendly interfaces).