This repository has been archived by the owner on May 23, 2020. It is now read-only.
Use AutoValue for data classes #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving to AutoValue makes the whole library more stable and also simpler to maintain. Only downside is that this changes the method signature on RequestPermissionsResult.permissions(), since String[] is not allowed in AutoValue classes.
vanniktech
reviewed
Oct 31, 2016
| @@ -5,6 +5,7 @@ buildscript { | |||
| dependencies { | |||
| classpath 'com.android.tools.build:gradle:2.2.2' | |||
| classpath 'com.github.ben-manes:gradle-versions-plugin:0.13.0' | |||
| classpath 'com.neenbedankt.gradle.plugins:android-apt:1.8' | |||
There was a problem hiding this comment.
You don't need this anymore with 2.2.0 as of gadle build tools. Use 'annotationProcessor' instead
There was a problem hiding this comment.
Interesting, though it looks like (from the docs) you can only do this if you're using Jack & Jill. Is that false? http://tools.android.com/tech-docs/jackandjill#TOC-Repackaging-support
There was a problem hiding this comment.
Yup this is false. You don't need to use Jack & Jill.
There was a problem hiding this comment.
Might also be interesting: http://www.littlerobots.nl/blog/Whats-next-for-android-apt/
There was a problem hiding this comment.
Cool, good to know. Here's the fix: #78
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving to AutoValue makes the whole library more stable and also
simpler to maintain.
Only downside is that this changes the method signature on
RequestPermissionsResult.permissions(), since String[] is not allowed
in AutoValue classes.