Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misses half of the player in Elden ring Arena #30

Closed
taoli0515 opened this issue Apr 15, 2023 · 2 comments · Fixed by #38
Closed

Misses half of the player in Elden ring Arena #30

taoli0515 opened this issue Apr 15, 2023 · 2 comments · Fixed by #38

Comments

@taoli0515
Copy link

Half of the player are missed from by the app - tested over multiple back to back arena session. The very first session almost never misses, which lead me to believe It might have to do with back to back queuing

@tremwil
Copy link
Owner

tremwil commented Apr 16, 2023

Hi, the reason for this is that the peer detection method currently isn't very reliable when you are the owner of your session's Steam lobby (in the arena, you should expect to be the lobby owner about 50% of the time). In non-arena multiplayer, that player is the host.

I see 2 possible fixes for this problem:

  1. Return to the detection method used by my Dark Souls 3 tool, which involves periodically fetching the list of recently encountered players and checking for active P2P connections. I didn't do this at first because Elden Ring used to not add players on this list (until update 1.04).
  2. It may also be possible to fix this by using log_matchmaking_callbacks in the Steam console and making use of the LobbyChatUpdate callback dumps to find peers.

I don't currently have time to work on this project, and one of the next ones I will be working on will be an Elden Ring specific tool that uses an internal Steam hook to provide detailed connection information and more (like player character names, rune levels, etc). However, if anyone is willing to implement either of these fixes and submit a PR, I will happily accept it. Note, however, that solution 2 would be preferred, as it would mean compatibility with more games.

@tremwil
Copy link
Owner

tremwil commented Feb 1, 2024

Fixed in 1.1.0.

@tremwil tremwil closed this as completed Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants