Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we use "px" or "rem" value units for the v1.0 release? #227

Closed
cheton opened this issue Sep 7, 2020 · 2 comments
Closed

Should we use "px" or "rem" value units for the v1.0 release? #227

cheton opened this issue Sep 7, 2020 · 2 comments
Labels
💬 discussion This is a request for comments

Comments

@cheton
Copy link
Member

cheton commented Sep 7, 2020

No description provided.

@cheton cheton changed the title Should we use px or rem value units in v1 release? Should we use "px" or "rem" value units for the v1.0 release? Sep 7, 2020
@cheton cheton added the 💬 discussion This is a request for comments label Sep 7, 2020
@austinhung81
Copy link
Contributor

We can discuss tomorrow 👍

@cheton cheton pinned this issue Sep 11, 2020
@cheton
Copy link
Member Author

cheton commented Sep 22, 2020

keep both

@cheton cheton closed this as completed Sep 22, 2020
@cheton cheton unpinned this issue Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💬 discussion This is a request for comments
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cheton @austinhung81