Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encode_21 not in source #4

Closed
thoho opened this issue Nov 26, 2017 · 7 comments
Closed

encode_21 not in source #4

thoho opened this issue Nov 26, 2017 · 7 comments

Comments

@thoho
Copy link

thoho commented Nov 26, 2017

The method encode_21 for A-to-N messages is not present in the code even tough it is called.

@ghost
Copy link

ghost commented Nov 27, 2017

Im having a hard time finding any reference to an encode_21 method. Could you point me to the file and line number you are seeing this on?

Edit: I found it in AIVDM_Encoder.py Which I have never used. Shouldn't be to hard to add encode_21. Perhaps I will look into it.

@thoho
Copy link
Author

thoho commented Nov 27, 2017

AIVDM_Encoder.py#L290
OK. Seemed strange that the option for AtoN was there but the encoding wasn't! :-)

@ghost
Copy link

ghost commented Nov 29, 2017

Try this and let me know if it works for you: https://github.com/zhudsonSM/aistx/tree/msg21fix

@thoho
Copy link
Author

thoho commented Nov 29, 2017

Yes, seems to work and encode OK as verified by a few online decoders (eg http://www.aggsoft.com/ais-decoder.htm).
Thanks!

@ghost ghost mentioned this issue Nov 29, 2017
@ghost
Copy link

ghost commented Nov 29, 2017

I created a pull request: #5
I do not think that trendmicro is maintaining this any more so it will probably stay unmerged

@embyte0
Copy link
Collaborator

embyte0 commented Dec 4, 2018

Hi all,

I was not maintaining this code until now, when I recently received few feature additions -- that I just committed. I will now take a look at the pull requests and most likely merge!

Thanks for this.

PS. As it normally happen in research labs, we often move forward when a research is done. That's why I don't allocate time to enhance or maintain code of completed projects. But I am more than happy to support contributors at any time: don't hesitate to contact me, better via email!

Marco embyte Balduzzi

This was referenced Dec 4, 2018
@embyte0
Copy link
Collaborator

embyte0 commented Dec 4, 2018

Done

@embyte0 embyte0 closed this as completed Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants